Commit 5db465f2 authored Aug 04, 2017 by Dan Carpenter Committed by Doug Ledford Aug 04, 2017

IB/hns: checking for IS_ERR() instead of NULL



The hns_roce_v1_create_lp_qp() returns NULL on error, not error pointers.

Fixes: bfcc681b ("IB/hns: Fix the bug when free mr")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 931b3c1a

drivers/infiniband/hw/hns/hns_roce_hw_v1.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -733,7 +733,7 @@ static int hns_roce_v1_rsv_lp_qp(struct hns_roce_dev *hr_dev)
		continue;

		free_mr->mr_free_qp[i] = hns_roce_v1_create_lp_qp(hr_dev, pd);
		if (IS_ERR(free_mr->mr_free_qp[i])) {
		if (!free_mr->mr_free_qp[i]) {
		dev_err(dev, "Create loop qp failed!\n");
		goto create_lp_qp_failed;
		}