Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5dab5872 authored by Jan Kiszka's avatar Jan Kiszka Committed by Linus Walleij
Browse files

gpio: exar: Allocate resources on behalf of the platform device 



Do not allocate resources on behalf of the parent device but on our own.
Otherwise, cleanup does not properly work if gpio-exar is removed but
not the parent device.

Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent d3936d74

drivers/gpio/gpio-exar.c

+2 −2
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ static int gpio_exar_probe(struct platform_device *pdev) 
	if (!p)

		return -ENOMEM;



	exar_gpio = devm_kzalloc(&pcidev->dev, sizeof(*exar_gpio), GFP_KERNEL);

	exar_gpio = devm_kzalloc(&pdev->dev, sizeof(*exar_gpio), GFP_KERNEL);

	if (!exar_gpio)

		return -ENOMEM;
@@ -160,7 +160,7 @@ static int gpio_exar_probe(struct platform_device *pdev) 
	exar_gpio->regs = p;

	exar_gpio->index = index;



	ret = devm_gpiochip_add_data(&pcidev->dev,

	ret = devm_gpiochip_add_data(&pdev->dev,

				     &exar_gpio->gpio_chip, exar_gpio);

	if (ret)

		goto err_destroy;