Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d49d603 authored by Vivien Didelot's avatar Vivien Didelot Committed by David S. Miller
Browse files

net: dsa: mv88e6xxx: remove Global 2 setup 



The remaining values written to the Switch Management Register in the
mv88e6xxx_g2_setup function are specific to 88E6352 and older, and are
the default values anyway.

Thus remove completely this function. The mv88e6xxx driver no more
contains setup code to access arbitrary Global 2 registers.

Signed-off-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7f047b6

drivers/net/dsa/mv88e6xxx/chip.c

+0 −7
Original line number Diff line number Diff line
@@ -2228,13 +2228,6 @@ static int mv88e6xxx_setup(struct dsa_switch *ds) 
	if (err)

		goto unlock;



	/* Setup Switch Global 2 Registers */

	if (chip->info->global2_addr) {

		err = mv88e6xxx_g2_setup(chip);

		if (err)

			goto unlock;

	}



	err = mv88e6xxx_irl_setup(chip);

	if (err)

		goto unlock;

drivers/net/dsa/mv88e6xxx/global2.c

+0 −18
Original line number Diff line number Diff line
@@ -1118,21 +1118,3 @@ void mv88e6xxx_g2_irq_mdio_free(struct mv88e6xxx_chip *chip, 
	for (phy = 0; phy < chip->info->num_internal_phys; phy++)

		irq_dispose_mapping(bus->irq[phy]);

}
 


int mv88e6xxx_g2_setup(struct mv88e6xxx_chip *chip)

{

	u16 reg;

	int err;



	/* Ignore removed tag data on doubly tagged packets, disable

	 * flow control messages, force flow control priority to the

	 * highest, and send all special multicast frames to the CPU

	 * port at the highest priority.

	 */

	reg = MV88E6XXX_G2_SWITCH_MGMT_FORCE_FLOW_CTL_PRI | (0x7 << 4);

	err = mv88e6xxx_g2_write(chip, MV88E6XXX_G2_SWITCH_MGMT, reg);

	if (err)

		return err;



	return 0;

}

drivers/net/dsa/mv88e6xxx/global2.h

+0 −6
Original line number Diff line number Diff line
@@ -314,7 +314,6 @@ int mv88e6xxx_g2_pvt_write(struct mv88e6xxx_chip *chip, int src_dev, 
			   int src_port, u16 data);

int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip);



int mv88e6xxx_g2_setup(struct mv88e6xxx_chip *chip);

int mv88e6xxx_g2_irq_setup(struct mv88e6xxx_chip *chip);

void mv88e6xxx_g2_irq_free(struct mv88e6xxx_chip *chip);
@@ -447,11 +446,6 @@ static inline int mv88e6xxx_g2_misc_4_bit_port(struct mv88e6xxx_chip *chip) 
	return -EOPNOTSUPP;

}



static inline int mv88e6xxx_g2_setup(struct mv88e6xxx_chip *chip)

{

	return -EOPNOTSUPP;

}



static inline int mv88e6xxx_g2_irq_setup(struct mv88e6xxx_chip *chip)

{

	return -EOPNOTSUPP;