Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d42ced1 authored by Jiong Wang's avatar Jiong Wang Committed by David S. Miller
Browse files

nfp: bpf: rename ALU_OP_NEG to ALU_OP_NOT 



The current ALU_OP_NEG is Op encoding 0x4 for NPF ALU instruction. It is
actually performing "~B" operation which is bitwise NOT.

The using naming ALU_OP_NEG is misleading as NEG is -B which is not the
same as ~B.

Signed-off-by: default avatarJiong Wang <jiong.wang@netronome.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 07d3c4af

drivers/net/ethernet/netronome/nfp/bpf/jit.c

+1 −1
Original line number Diff line number Diff line
@@ -944,7 +944,7 @@ wrp_alu_imm(struct nfp_prog *nfp_prog, u8 dst, enum alu_op alu_op, u32 imm) 
	if (alu_op == ALU_OP_XOR) {

		if (!~imm)

			emit_alu(nfp_prog, reg_both(dst), reg_none(),

				 ALU_OP_NEG, reg_b(dst));

				 ALU_OP_NOT, reg_b(dst));

		if (!imm || !~imm)

			return;

	}

drivers/net/ethernet/netronome/nfp/nfp_asm.h

+1 −1
Original line number Diff line number Diff line
@@ -174,7 +174,7 @@ enum shf_sc { 
enum alu_op {

	ALU_OP_NONE	= 0x00,

	ALU_OP_ADD	= 0x01,

	ALU_OP_NEG	= 0x04,

	ALU_OP_NOT	= 0x04,

	ALU_OP_AND	= 0x08,

	ALU_OP_SUB_C	= 0x0d,

	ALU_OP_ADD_C	= 0x11,