Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d414b17 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jason Gunthorpe
Browse files

IB/mlx5: Fix an error code in __mlx5_ib_modify_qp() 



"err" is either zero or possibly uninitialized here.  It should be
-EINVAL.

Fixes: 427c1e7b ("{IB, net}/mlx5: Move the modify QP operation table to mlx5_ib")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 210b1f78

drivers/infiniband/hw/mlx5/qp.c

+3 −1
Original line number Diff line number Diff line
@@ -3100,8 +3100,10 @@ static int __mlx5_ib_modify_qp(struct ib_qp *ibqp, 
		goto out;



	if (mlx5_cur >= MLX5_QP_NUM_STATE || mlx5_new >= MLX5_QP_NUM_STATE ||

	    !optab[mlx5_cur][mlx5_new])

	    !optab[mlx5_cur][mlx5_new]) {

		err = -EINVAL;

		goto out;

	}



	op = optab[mlx5_cur][mlx5_new];

	optpar = ib_mask_to_mlx5_opt(attr_mask);