Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5d07c2cc authored by Borislav Petkov's avatar Borislav Petkov Committed by Thomas Gleixner
Browse files

x86/msr: Cleanup/streamline MSR helpers 



Make the MSR argument an unsigned int, both low and high u32, put
"notrace" last in the function signature. Reflow function signatures for
better readability and cleanup white space.

Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 8ca22552

arch/x86/include/asm/msr.h

+21 −19
Original line number Diff line number Diff line
@@ -70,14 +70,14 @@ extern struct tracepoint __tracepoint_read_msr; 
extern struct tracepoint __tracepoint_write_msr;

extern struct tracepoint __tracepoint_rdpmc;

#define msr_tracepoint_active(t) static_key_false(&(t).key)

extern void do_trace_write_msr(unsigned msr, u64 val, int failed);

extern void do_trace_read_msr(unsigned msr, u64 val, int failed);

extern void do_trace_rdpmc(unsigned msr, u64 val, int failed);

extern void do_trace_write_msr(unsigned int msr, u64 val, int failed);

extern void do_trace_read_msr(unsigned int msr, u64 val, int failed);

extern void do_trace_rdpmc(unsigned int msr, u64 val, int failed);

#else

#define msr_tracepoint_active(t) false

static inline void do_trace_write_msr(unsigned msr, u64 val, int failed) {}

static inline void do_trace_read_msr(unsigned msr, u64 val, int failed) {}

static inline void do_trace_rdpmc(unsigned msr, u64 val, int failed) {}

static inline void do_trace_write_msr(unsigned int msr, u64 val, int failed) {}

static inline void do_trace_read_msr(unsigned int msr, u64 val, int failed) {}

static inline void do_trace_rdpmc(unsigned int msr, u64 val, int failed) {}

#endif



static inline unsigned long long native_read_msr(unsigned int msr)
@@ -115,8 +115,8 @@ static inline unsigned long long native_read_msr_safe(unsigned int msr, 
}



/* Can be uninlined because referenced by paravirt */

static notrace inline void __native_write_msr_notrace(unsigned int msr,

					    unsigned low, unsigned high)

static inline void notrace

__native_write_msr_notrace(unsigned int msr, u32 low, u32 high)

{

	asm volatile("1: wrmsr\n"

		     "2:\n"
@@ -125,24 +125,26 @@ static notrace inline void __native_write_msr_notrace(unsigned int msr, 
}



/* Can be uninlined because referenced by paravirt */

static notrace inline void native_write_msr(unsigned int msr,

					    unsigned low, unsigned high)

static inline void notrace

native_write_msr(unsigned int msr, u32 low, u32 high)

{

	__native_write_msr_notrace(msr, low, high);

	if (msr_tracepoint_active(__tracepoint_write_msr))

		do_trace_write_msr(msr, ((u64)high << 32 | low), 0);

}



static inline void wrmsr_notrace(unsigned msr, unsigned low, unsigned high)

static inline void

wrmsr_notrace(unsigned int msr, u32 low, u32 high)

{

	__native_write_msr_notrace(msr, low, high);

}



/* Can be uninlined because referenced by paravirt */

notrace static inline int native_write_msr_safe(unsigned int msr,

					unsigned low, unsigned high)

static inline int notrace

native_write_msr_safe(unsigned int msr, u32 low, u32 high)

{

	int err;



	asm volatile("2: wrmsr ; xor %[err],%[err]\n"

		     "1:\n\t"

		     ".section .fixup,\"ax\"\n\t"
@@ -235,7 +237,7 @@ do { \ 
	(void)((high) = (u32)(__val >> 32));			\

} while (0)



static inline void wrmsr(unsigned msr, unsigned low, unsigned high)

static inline void wrmsr(unsigned int msr, u32 low, u32 high)

{

	native_write_msr(msr, low, high);

}
@@ -243,13 +245,13 @@ static inline void wrmsr(unsigned msr, unsigned low, unsigned high) 
#define rdmsrl(msr, val)			\

	((val) = native_read_msr((msr)))



static inline void wrmsrl(unsigned msr, u64 val)

static inline void wrmsrl(unsigned int msr, u64 val)

{

	native_write_msr(msr, (u32)(val & 0xffffffffULL), (u32)(val >> 32));

}



/* wrmsr with exception handling */

static inline int wrmsr_safe(unsigned msr, unsigned low, unsigned high)

static inline int wrmsr_safe(unsigned int msr, u32 low, u32 high)

{

	return native_write_msr_safe(msr, low, high);

}
@@ -264,7 +266,7 @@ static inline int wrmsr_safe(unsigned msr, unsigned low, unsigned high) 
	__err;							\

})



static inline int rdmsrl_safe(unsigned msr, unsigned long long *p)

static inline int rdmsrl_safe(unsigned int msr, unsigned long long *p)

{

	int err;

arch/x86/lib/msr.c

+2 −2
Original line number Diff line number Diff line
@@ -113,14 +113,14 @@ int msr_clear_bit(u32 msr, u8 bit) 
}



#ifdef CONFIG_TRACEPOINTS

void do_trace_write_msr(unsigned msr, u64 val, int failed)

void do_trace_write_msr(unsigned int msr, u64 val, int failed)

{

	trace_write_msr(msr, val, failed);

}

EXPORT_SYMBOL(do_trace_write_msr);

EXPORT_TRACEPOINT_SYMBOL(write_msr);



void do_trace_read_msr(unsigned msr, u64 val, int failed)

void do_trace_read_msr(unsigned int msr, u64 val, int failed)

{

	trace_read_msr(msr, val, failed);

}