Commit 5d06e3df authored Sep 18, 2012 by Ian Abbott Committed by Greg Kroah-Hartman Sep 19, 2012

staging: comedi: don't dereference user memory for INSN_INTTRIG



`parse_insn()` is dereferencing the user-space pointer `insn->data`
directly when handling the `INSN_INTTRIG` comedi instruction.  It
shouldn't be using `insn->data` at all; it should be using the separate
`data` pointer passed to the function.  Fix it.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9f82e957

drivers/staging/comedi/comedi_fops.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -950,7 +950,7 @@ static int parse_insn(struct comedi_device dev, struct comedi_insn insn,
		ret = -EAGAIN;
		break;
		}
		ret = s->async->inttrig(dev, s, insn->data[0]);
		ret = s->async->inttrig(dev, s, data[0]);
		if (ret >= 0)
		ret = 1;
		break;