Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c602c39 authored by Necip Fazil Yildiran's avatar Necip Fazil Yildiran Committed by Greg Kroah-Hartman
Browse files

Input: resistive-adc-touch - fix kconfig dependency on IIO_BUFFER 



[ Upstream commit 676650d007e06fddcf3fe38238251d71bd179641 ]

When TOUCHSCREEN_ADC is enabled and IIO_BUFFER is disabled, it results
in the following Kbuild warning:

WARNING: unmet direct dependencies detected for IIO_BUFFER_CB
  Depends on [n]: IIO [=y] && IIO_BUFFER [=n]
  Selected by [y]:
  - TOUCHSCREEN_ADC [=y] && !UML && INPUT [=y] && INPUT_TOUCHSCREEN [=y] && IIO [=y]

The reason is that TOUCHSCREEN_ADC selects IIO_BUFFER_CB without depending
on or selecting IIO_BUFFER while IIO_BUFFER_CB depends on IIO_BUFFER. This
can also fail building the kernel.

Honor the kconfig dependency to remove unmet direct dependency warnings
and avoid any potential build failures.

Fixes: aa132ffb ("input: touchscreen: resistive-adc-touch: add generic resistive ADC touchscreen")
Signed-off-by: default avatarNecip Fazil Yildiran <fazilyildiran@gmail.com>
Acked-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20201102221504.541279-1-fazilyildiran@gmail.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 84820e91

drivers/input/touchscreen/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -95,6 +95,7 @@ config TOUCHSCREEN_AD7879_SPI 
config TOUCHSCREEN_ADC

	tristate "Generic ADC based resistive touchscreen"

	depends on IIO

	select IIO_BUFFER

	select IIO_BUFFER_CB

	help

	  Say Y here if you want to use the generic ADC