Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5c08d7e4 authored by Linus Walleij's avatar Linus Walleij Committed by Greg Kroah-Hartman
Browse files

net: dsa: rtl8366: Check VLAN ID and not ports 



[ Upstream commit e8521e53cca584ddf8ec4584d3c550a6c65f88c4 ]

There has been some confusion between the port number and
the VLAN ID in this driver. What we need to check for
validity is the VLAN ID, nothing else.

The current confusion came from assigning a few default
VLANs for default routing and we need to rewrite that
properly.

Instead of checking if the port number is a valid VLAN
ID, check the actual VLAN IDs passed in to the callback
one by one as expected.

Fixes: d8652956 ("net: dsa: realtek-smi: Add Realtek SMI driver")
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3c1f0704

drivers/net/dsa/rtl8366.c

+7 −4
Original line number Diff line number Diff line
@@ -339,9 +339,11 @@ int rtl8366_vlan_prepare(struct dsa_switch *ds, int port, 
			 const struct switchdev_obj_port_vlan *vlan)

{

	struct realtek_smi *smi = ds->priv;

	u16 vid;

	int ret;



	if (!smi->ops->is_vlan_valid(smi, port))

	for (vid = vlan->vid_begin; vid < vlan->vid_end; vid++)

		if (!smi->ops->is_vlan_valid(smi, vid))

			return -EINVAL;



	dev_info(smi->dev, "prepare VLANs %04x..%04x\n",
@@ -370,7 +372,8 @@ void rtl8366_vlan_add(struct dsa_switch *ds, int port, 
	u16 vid;

	int ret;



	if (!smi->ops->is_vlan_valid(smi, port))

	for (vid = vlan->vid_begin; vid < vlan->vid_end; vid++)

		if (!smi->ops->is_vlan_valid(smi, vid))

			return;



	dev_info(smi->dev, "add VLAN on port %d, %s, %s\n",