Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b9d47cd authored by Dan Carpenter's avatar Dan Carpenter Committed by Emmanuel Grumbach
Browse files

iwlwifi: mvm: fix a range check in debugfs code 



The &mvm->tof_data.range_req.ap[] array has IWL_MVM_TOF_MAX_APS elements
so the check should be >= instead of >.  Also the test can underflow so
I have changed "i" to unsigned.

Fixes: ce792918 ('wlwifi: mvm: add basic Time of Flight (802.11mc FTM) support')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
parent 3cd6e2f7

drivers/net/wireless/iwlwifi/mvm/debugfs-vif.c

+3 −3
Original line number Diff line number Diff line
@@ -911,9 +911,9 @@ static ssize_t iwl_dbgfs_tof_range_request_write(struct ieee80211_vif *vif, 
		int size = sizeof(struct iwl_tof_range_req_ap_entry);

		u16 burst_period;

		u8 *mac = ap.bssid;

		int i;

		unsigned int i;



		if (sscanf(data, "%d %hhd %hhx %hhx"

		if (sscanf(data, "%u %hhd %hhx %hhx"

			   "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx"

			   "%hhx %hhx %hx"

			   "%hhx %hhx %x"
@@ -929,7 +929,7 @@ static ssize_t iwl_dbgfs_tof_range_request_write(struct ieee80211_vif *vif, 
			ret = -EINVAL;

			goto out;

		}

		if (i > IWL_MVM_TOF_MAX_APS) {

		if (i >= IWL_MVM_TOF_MAX_APS) {

			IWL_ERR(mvm, "Invalid AP index %d\n", i);

			ret = -EINVAL;

			goto out;