Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5b2c4b97 authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

net: fix network drivers ndo_start_xmit() return values (part 8) 



Fix up USB drivers that return an errno value (result of usb_submit_urb())
to qdisc_restart(), causing qdisc_restart() to print a warning and requeue/
retransmit the skb.

- hso: skb is freed: use after free
- at76_usb: skb is freed: use after free

Compile tested only.

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 81fbbf60

drivers/net/usb/hso.c

+1 −1
Original line number Diff line number Diff line
@@ -816,7 +816,7 @@ static int hso_net_start_xmit(struct sk_buff *skb, struct net_device *net) 
	}

	dev_kfree_skb(skb);

	/* we're done */

	return result;

	return NETDEV_TX_OK;

}



static void hso_get_drvinfo(struct net_device *net, struct ethtool_drvinfo *info)

drivers/staging/at76_usb/at76_usb.c

+3 −4
Original line number Diff line number Diff line
@@ -3242,12 +3242,11 @@ static int at76_tx(struct sk_buff *skb, struct net_device *netdev) 
			       "%s: -EINVAL: tx urb %p hcpriv %p complete %p\n",

			       priv->netdev->name, priv->tx_urb,

			       priv->tx_urb->hcpriv, priv->tx_urb->complete);

	} else {

	} else

		stats->tx_bytes += skb->len;

		dev_kfree_skb(skb);

	}



	return ret;

	dev_kfree_skb(skb);

	return NETDEV_TX_OK;

}



static void at76_tx_timeout(struct net_device *netdev)