Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ada5773 authored by Andy Walls's avatar Andy Walls Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (13910): cx18: Fix set indextable command to properly select I/P/B index entries 



The CX18_CPU_SET_INDEXTABLE command was being called with the wrong number
of arguments causing the index table frame type selection mask to be set wrong.
Now the IDX stream properly sends entries for I, P, and B frames.

Signed-off-by: default avatarAndy Walls <awalls@radix.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 9bff2d61

drivers/media/video/cx18/cx18-streams.c

+2 −2
Original line number Diff line number Diff line
@@ -686,8 +686,8 @@ int cx18_start_v4l2_encode_stream(struct cx18_stream *s) 
		 * generation.

		 */

		s_idx = &cx->streams[CX18_ENC_STREAM_TYPE_IDX];

		cx18_vapi_result(cx, data, CX18_CPU_SET_INDEXTABLE, 1,

				 cx18_stream_enabled(s_idx) ? 7 : 0);

		cx18_vapi_result(cx, data, CX18_CPU_SET_INDEXTABLE, 2,

				 s->handle, cx18_stream_enabled(s_idx) ? 7 : 0);



		/* Call out to the common CX2341x API setup for user controls */

		priv.cx = cx;

drivers/media/video/cx18/cx23418.h

+2 −1
Original line number Diff line number Diff line
@@ -191,7 +191,8 @@ 
#define CX18_CPU_SET_MEDIAN_CORING           	(CPU_CMD_MASK_CAPTURE | 0x000E)



/* Description: This command set the picture type mask for index file

   IN[0] - 	0 = disable index file output

   IN[0] - Task handle (ignored by firmware)

   IN[1] - 	0 = disable index file output

			1 = output I picture

			2 = P picture

			4 = B picture