Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ab42d16 authored Mar 22, 2021 by dongjian Committed by Greg Kroah-Hartman May 22, 2021

power: supply: Use IRQF_ONESHOT



[ Upstream commit 2469b836fa835c67648acad17d62bc805236a6ea ]

Fixes coccicheck error:

drivers/power/supply/pm2301_charger.c:1089:7-27: ERROR:
drivers/power/supply/lp8788-charger.c:502:8-28: ERROR:
drivers/power/supply/tps65217_charger.c:239:8-33: ERROR:
drivers/power/supply/tps65090-charger.c:303:8-33: ERROR:

Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Signed-off-by: dongjian <dongjian@yulong.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fa617521

drivers/power/supply/lp8788-charger.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -529,7 +529,7 @@ static int lp8788_set_irqs(struct platform_device *pdev,

	ret = request_threaded_irq(virq, NULL,		ret = request_threaded_irq(virq, NULL,
	lp8788_charger_irq_thread,		lp8788_charger_irq_thread,
	0, name, pchg);		IRQF_ONESHOT, name, pchg);
	if (ret)		if (ret)
	break;		break;
	}		}

drivers/power/supply/pm2301_charger.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1098,7 +1098,7 @@ static int pm2xxx_wall_charger_probe(struct i2c_client *i2c_client,
	ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number),		ret = request_threaded_irq(gpio_to_irq(pm2->pdata->gpio_irq_number),
	NULL,		NULL,
	pm2xxx_charger_irq[0].isr,		pm2xxx_charger_irq[0].isr,
	pm2->pdata->irq_type,		pm2->pdata->irq_type \| IRQF_ONESHOT,
	pm2xxx_charger_irq[0].name, pm2);		pm2xxx_charger_irq[0].name, pm2);

	if (ret != 0) {		if (ret != 0) {

drivers/power/supply/tps65090-charger.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -311,7 +311,7 @@ static int tps65090_charger_probe(struct platform_device *pdev)

	if (irq != -ENXIO) {		if (irq != -ENXIO) {
	ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
	tps65090_charger_isr, 0, "tps65090-charger", cdata);		tps65090_charger_isr, IRQF_ONESHOT, "tps65090-charger", cdata);
	if (ret) {		if (ret) {
	dev_err(cdata->dev,		dev_err(cdata->dev,
	"Unable to register irq %d err %d\n", irq,		"Unable to register irq %d err %d\n", irq,

drivers/power/supply/tps65217_charger.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev)
	for (i = 0; i < NUM_CHARGER_IRQS; i++) {		for (i = 0; i < NUM_CHARGER_IRQS; i++) {
	ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL,		ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL,
	tps65217_charger_irq,		tps65217_charger_irq,
	0, "tps65217-charger",		IRQF_ONESHOT, "tps65217-charger",
	charger);		charger);
	if (ret) {		if (ret) {
	dev_err(charger->dev,		dev_err(charger->dev,