Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a063d87 authored by Thierry Reding's avatar Thierry Reding
Browse files

pwm: sysfs: Properly convert from enum to string 



The current code will check for polarity in a boolean way. While it is
correct that polarity is either normal or inversed, make it more obvious
that it's an enumeration by using a switch statement and explicit
matches on the enumeration values.

Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 15da7b50

drivers/pwm/sysfs.c

+12 −2
Original line number Diff line number Diff line
@@ -133,9 +133,19 @@ static ssize_t pwm_polarity_show(struct device *child, 
				 char *buf)

{

	const struct pwm_device *pwm = child_to_pwm_device(child);

	const char *polarity = "unknown";



	return sprintf(buf, "%s\n",

		       pwm_get_polarity(pwm) ? "inversed" : "normal");

	switch (pwm_get_polarity(pwm)) {

	case PWM_POLARITY_NORMAL:

		polarity = "normal";

		break;



	case PWM_POLARITY_INVERSED:

		polarity = "inversed";

		break;

	}



	return sprintf(buf, "%s\n", polarity);

}



static ssize_t pwm_polarity_store(struct device *child,