Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59ed2b7a authored by Saurav Girepunje's avatar Saurav Girepunje Committed by Greg Kroah-Hartman
Browse files

ALSA: usb-audio: sound: usb: usb true/false for bool return type 



commit 1d4961d9eb1aaa498dfb44779b7e4b95d79112d0 upstream.

Use true/false for bool type return in uac_clock_source_is_valid().

Signed-off-by: default avatarSaurav Girepunje <saurav.girepunje@gmail.com>
Link: https://lore.kernel.org/r/20191029175200.GA7320@saurav


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e074c64a

sound/usb/clock.c

+5 −5
Original line number Diff line number Diff line
@@ -179,21 +179,21 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip, 
			snd_usb_find_clock_source_v3(chip->ctrl_intf, source_id);



		if (!cs_desc)

			return 0;

			return false;

		bmControls = le32_to_cpu(cs_desc->bmControls);

	} else { /* UAC_VERSION_1/2 */

		struct uac_clock_source_descriptor *cs_desc =

			snd_usb_find_clock_source(chip->ctrl_intf, source_id);



		if (!cs_desc)

			return 0;

			return false;

		bmControls = cs_desc->bmControls;

	}



	/* If a clock source can't tell us whether it's valid, we assume it is */

	if (!uac_v2v3_control_is_readable(bmControls,

				      UAC2_CS_CONTROL_CLOCK_VALID))

		return 1;

		return true;



	err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC2_CS_CUR,

			      USB_TYPE_CLASS | USB_RECIP_INTERFACE | USB_DIR_IN,
@@ -205,10 +205,10 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip, 
		dev_warn(&dev->dev,

			 "%s(): cannot get clock validity for id %d\n",

			   __func__, source_id);

		return 0;

		return false;

	}



	return !!data;

	return data ? true :  false;

}



static int __uac_clock_find_source(struct snd_usb_audio *chip, int entity_id,