Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59de2beb authored by Shaohua Li's avatar Shaohua Li Committed by Dave Airlie
Browse files

agp: zero pages before sending to userspace 



AGP pages might be mapped into userspace finally, so the pages should be
set to zero before userspace can use it. Otherwise there is potential
information leakage.

Signed-off-by: default avatarShaohua Li <shaohua.li@intel.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 07f1c7a7

drivers/char/agp/generic.c

+2 −2
Original line number Diff line number Diff line
@@ -1226,7 +1226,7 @@ int agp_generic_alloc_pages(struct agp_bridge_data *bridge, struct agp_memory *m 
	int i, ret = -ENOMEM;



	for (i = 0; i < num_pages; i++) {

		page = alloc_page(GFP_KERNEL | GFP_DMA32);

		page = alloc_page(GFP_KERNEL | GFP_DMA32 | __GFP_ZERO);

		/* agp_free_memory() needs gart address */

		if (page == NULL)

			goto out;
@@ -1257,7 +1257,7 @@ void *agp_generic_alloc_page(struct agp_bridge_data *bridge) 
{

	struct page * page;



	page = alloc_page(GFP_KERNEL | GFP_DMA32);

	page = alloc_page(GFP_KERNEL | GFP_DMA32 | __GFP_ZERO);

	if (page == NULL)

		return NULL;