Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 59adb398 authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPI / debugger: Fix a redundant mutex unlock issue in acpi_aml_open() 



Fix a double mutex_unlock() issue where acpi_initialize_debugger() is
called with the mutex already unlocked.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent ec74765d

drivers/acpi/acpi_dbg.c

+2 −1
Original line number Diff line number Diff line
@@ -514,7 +514,7 @@ static int acpi_aml_open(struct inode *inode, struct file *file) 
		if (ACPI_FAILURE(status)) {

			pr_err("Failed to initialize debugger.\n");

			ret = -EINVAL;

			goto err_lock;

			goto err_exit;

		}

		pr_debug("Debugger thread initialized.\n");
@@ -531,6 +531,7 @@ static int acpi_aml_open(struct inode *inode, struct file *file) 
			acpi_aml_active_reader = NULL;

	}

	mutex_unlock(&acpi_aml_io.lock);

err_exit:

	return ret;

}