Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 598a0df0 authored by Kees Cook's avatar Kees Cook Committed by John W. Linville
Browse files

rtlwifi: prevent format string usage from leaking 



Use "%s" in the workqueue allocation to make sure the rtl_hal_cfg name
can never accidentally leak information via a format string.

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 34b6d429

drivers/net/wireless/rtlwifi/base.c

+1 −1
Original line number Diff line number Diff line
@@ -467,7 +467,7 @@ static void _rtl_init_deferred_work(struct ieee80211_hw *hw) 
		    rtl_easy_concurrent_retrytimer_callback, (unsigned long)hw);

	/* <2> work queue */

	rtlpriv->works.hw = hw;

	rtlpriv->works.rtl_wq = alloc_workqueue(rtlpriv->cfg->name, 0, 0);

	rtlpriv->works.rtl_wq = alloc_workqueue("%s", 0, 0, rtlpriv->cfg->name);

	INIT_DELAYED_WORK(&rtlpriv->works.watchdog_wq,

			  (void *)rtl_watchdog_wq_callback);

	INIT_DELAYED_WORK(&rtlpriv->works.ips_nic_off_wq,