Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 596f2d05 authored by Eugene Teo's avatar Eugene Teo Committed by John W. Linville
Browse files

[PATCH] drivers/net/wireless/libertas/fw.c: fix use-before-check 



NULL checks should be performed before the dereference.

Spotted by the Coverity checker.

Signed-off-by: default avatarEugene Teo <eteo@redhat.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 3d4bd24b

drivers/net/wireless/libertas/fw.c

+9 −5
Original line number Diff line number Diff line
@@ -333,18 +333,22 @@ static void command_timer_fn(unsigned long data) 
	unsigned long flags;



	ptempnode = adapter->cur_cmd;

	if (ptempnode == NULL) {

		lbs_pr_debug(1, "PTempnode Empty\n");

		return;

	}



	cmd = (struct cmd_ds_command *)ptempnode->bufvirtualaddr;

	if (!cmd) {

		lbs_pr_debug(1, "cmd is NULL\n");

		return;

	}



	lbs_pr_info("command_timer_fn fired (%x)\n", cmd->command);



	if (!adapter->fw_ready)

		return;



	if (ptempnode == NULL) {

		lbs_pr_debug(1, "PTempnode Empty\n");

		return;

	}



	spin_lock_irqsave(&adapter->driver_lock, flags);

	adapter->cur_cmd = NULL;

	spin_unlock_irqrestore(&adapter->driver_lock, flags);