Commit 59691367 authored Mar 11, 2013 by Wei Yongjun Committed by Greg Kroah-Hartman Mar 11, 2013

staging: sync: fix return value check in sync_fence_alloc()



In case of error, the function anon_inode_getfile() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 70c1e91f

drivers/staging/android/sync.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -261,7 +261,7 @@ static struct sync_fence sync_fence_alloc(const char name)

		fence->file = anon_inode_getfile("sync_fence", &sync_fence_fops,
		fence, 0);
		if (fence->file == NULL)
		if (IS_ERR(fence->file))
		goto err;

		kref_init(&fence->kref);