Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 588fc3bc authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

gpiolib: don't allow OPEN_DRAIN & OPEN_SOURCE flags simultaneously 



Do not allow OPEN_SOURCE & OPEN_DRAIN flags in a single request. If
the hardware actually supports enabling both at the same time the
electrical result would be disastrous.

Suggested-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent e1c73a99

drivers/gpio/gpiolib.c

+9 −0
Original line number Diff line number Diff line
@@ -459,6 +459,15 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip) 
	if (lflags & ~GPIOHANDLE_REQUEST_VALID_FLAGS)

		return -EINVAL;



	/*

	 * Do not allow OPEN_SOURCE & OPEN_DRAIN flags in a single request. If

	 * the hardware actually supports enabling both at the same time the

	 * electrical result would be disastrous.

	 */

	if ((lflags & GPIOHANDLE_REQUEST_OPEN_DRAIN) &&

	    (lflags & GPIOHANDLE_REQUEST_OPEN_SOURCE))

		return -EINVAL;



	/* OPEN_DRAIN and OPEN_SOURCE flags only make sense for output mode. */

	if (!(lflags & GPIOHANDLE_REQUEST_OUTPUT) &&

	    ((lflags & GPIOHANDLE_REQUEST_OPEN_DRAIN) ||