Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 580c3432 authored by Hangyu Hua's avatar Hangyu Hua Committed by PavanKumar S.R
Browse files

UPSTREAM: usb: gadget: don't release an existing dev->buf 



commit 89f3594d0de58e8a57d92d497dea9fee3d4b9cda upstream.

dev->buf does not need to be released if it already exists before
executing dev_config.

Bug: 220261709
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20211231172138.7993-2-hbh25y@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Change-Id: Id53d6770fbae0a7fcf0fa136157c0ab34fb5da64
Git-commit: ff0000fe82f45cee26c83abb40b01e43c52739e9
Git-repo: https://android.googlesource.com/kernel/common


Signed-off-by: default avatarPavanKumar S.R <quic_pavasr@quicinc.com>
parent 447fa26c

drivers/usb/gadget/legacy/inode.c

+2 −1
Original line number Diff line number Diff line
@@ -1828,8 +1828,9 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) 
	spin_lock_irq (&dev->lock);

	value = -EINVAL;

	if (dev->buf) {

		spin_unlock_irq(&dev->lock);

		kfree(kbuf);

		goto fail;

		return value;

	}

	dev->buf = kbuf;