Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 578dc59f authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: comedi: ni_tio: remove some dead code 



These conditions can never be true because "i" is always one more than
NI_660X_MAX_RTSI_CHAN after the loop.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1a4493c5

drivers/staging/comedi/drivers/ni_tio.c

+0 −12
Original line number Diff line number Diff line
@@ -1012,14 +1012,10 @@ static unsigned ni_660x_gate_to_generic_gate(unsigned gate) 
			if (gate == NI_660X_RTSI_GATE_SEL(i))

				return NI_GPCT_RTSI_GATE_SELECT(i);

		}

		if (i <= NI_660X_MAX_RTSI_CHAN)

			break;

		for (i = 0; i <= NI_660X_MAX_GATE_PIN; ++i) {

			if (gate == NI_660X_PIN_GATE_SEL(i))

				return NI_GPCT_GATE_PIN_GATE_SELECT(i);

		}

		if (i <= NI_660X_MAX_GATE_PIN)

			break;

		BUG();

		break;

	}
@@ -1052,14 +1048,10 @@ static unsigned ni_m_gate_to_generic_gate(unsigned gate) 
			if (gate == NI_M_RTSI_GATE_SEL(i))

				return NI_GPCT_RTSI_GATE_SELECT(i);

		}

		if (i <= NI_M_MAX_RTSI_CHAN)

			break;

		for (i = 0; i <= NI_M_MAX_PFI_CHAN; ++i) {

			if (gate == NI_M_PFI_GATE_SEL(i))

				return NI_GPCT_PFI_GATE_SELECT(i);

		}

		if (i <= NI_M_MAX_PFI_CHAN)

			break;

		BUG();

		break;

	}
@@ -1088,14 +1080,10 @@ static unsigned ni_660x_gate2_to_generic_gate(unsigned gate) 
			if (gate == NI_660X_RTSI_GATE2_SEL(i))

				return NI_GPCT_RTSI_GATE_SELECT(i);

		}

		if (i <= NI_660X_MAX_RTSI_CHAN)

			break;

		for (i = 0; i <= NI_660X_MAX_UP_DOWN_PIN; ++i) {

			if (gate == NI_660X_UD_PIN_GATE2_SEL(i))

				return NI_GPCT_UP_DOWN_PIN_GATE_SELECT(i);

		}

		if (i <= NI_660X_MAX_UP_DOWN_PIN)

			break;

		BUG();

		break;

	}