Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57767e78 authored by Cong Wang's avatar Cong Wang Committed by David S. Miller
Browse files

cls_matchall: use tcf_exts_get_net() before call_rcu() 



Hold netns refcnt before call_rcu() and release it after
the tcf_exts_destroy() is done.

Cc: Lucas Bates <lucasb@mojatatu.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d5f984f5

net/sched/cls_matchall.c

+12 −3
Original line number Diff line number Diff line
@@ -44,13 +44,19 @@ static int mall_init(struct tcf_proto *tp) 
	return 0;

}



static void __mall_destroy(struct cls_mall_head *head)

{

	tcf_exts_destroy(&head->exts);

	tcf_exts_put_net(&head->exts);

	kfree(head);

}



static void mall_destroy_work(struct work_struct *work)

{

	struct cls_mall_head *head = container_of(work, struct cls_mall_head,

						  work);

	rtnl_lock();

	tcf_exts_destroy(&head->exts);

	kfree(head);

	__mall_destroy(head);

	rtnl_unlock();

}
@@ -109,7 +115,10 @@ static void mall_destroy(struct tcf_proto *tp) 
	if (tc_should_offload(dev, head->flags))

		mall_destroy_hw_filter(tp, head, (unsigned long) head);



	if (tcf_exts_get_net(&head->exts))

		call_rcu(&head->rcu, mall_destroy_rcu);

	else

		__mall_destroy(head);

}



static void *mall_get(struct tcf_proto *tp, u32 handle)