Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 574746dd authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: phy: properly report internal PHYs through sysfs 



Internal PHYs may not have a valid PHY interface defined, which will
show up in sysfs as "". Add an explicit check of internal PHYs to report
their interface correctly.

Fixes: 3d055d8d ("net: phy: expose PHY device interface mode")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 879ece6e

drivers/net/phy/mdio_bus.c

+7 −1
Original line number Diff line number Diff line
@@ -553,8 +553,14 @@ static ssize_t 
phy_interface_show(struct device *dev, struct device_attribute *attr, char *buf)

{

	struct phy_device *phydev = to_phy_device(dev);

	const char *mode = NULL;



	return sprintf(buf, "%s\n", phy_modes(phydev->interface));

	if (phy_is_internal(phydev))

		mode = "internal";

	else

		mode = phy_modes(phydev->interface);



	return sprintf(buf, "%s\n", mode);

}

static DEVICE_ATTR_RO(phy_interface);