Commit 5733959d authored Dec 21, 2023 by Hugo Villeneuve Committed by Greg Kroah-Hartman Feb 23, 2024

serial: sc16is7xx: set safe default SPI clock frequency



[ Upstream commit 3ef79cd1412236d884ab0c46b4d1921380807b48 ]

15 MHz is supported only by 76x variants.

If the SPI clock frequency is not specified, use a safe default clock value
of 4 MHz that is supported by all variants.

Also use HZ_PER_MHZ macro to improve readability.

Fixes: 2c837a8a ("sc16is7xx: spi interface is added")
Cc:  <stable@vger.kernel.org>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20231221231823.2327894-4-hugo@hugovil.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fe79b37c

drivers/tty/serial/sc16is7xx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -24,6 +24,7 @@
		#include <linux/tty_flip.h>
		#include <linux/spi/spi.h>
		#include <linux/uaccess.h>
		#include <linux/units.h>
		#include <uapi/linux/sched/types.h>

		#define SC16IS7XX_NAME "sc16is7xx"
		@@ -1408,7 +1409,7 @@ static int sc16is7xx_spi_probe(struct spi_device *spi)
		spi->bits_per_word = 8;
		/* only supports mode 0 on SC16IS762 */
		spi->mode = spi->mode ? : SPI_MODE_0;
		spi->max_speed_hz = spi->max_speed_hz ? : 15000000;
		spi->max_speed_hz = spi->max_speed_hz ? : 4 * HZ_PER_MHZ;
		ret = spi_setup(spi);
		if (ret)
		return ret;