Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5722963a authored by Ursula Braun's avatar Ursula Braun Committed by David S. Miller
Browse files

qeth: do not turn on SG per default 



According to recent performance measurements, turning on net_device
feature NETIF_F_SG only behaves well, but turning on feature
NETIF_F_GSO shows bad results. Since the kernel activates NETIF_F_GSO
automatically as soon as the driver configures feature NETIF_F_SG, qeth
should not activate feature NETIF_F_SG per default, until the qeth
problems with NETIF_F_GSO are solved.

Signed-off-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Reviewed-by: default avatarThomas Richter <tmricht@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 243f750f

drivers/s390/net/qeth_l2_main.c

+0 −2
Original line number Diff line number Diff line
@@ -1124,8 +1124,6 @@ static int qeth_l2_setup_netdev(struct qeth_card *card) 
			card->dev->hw_features |= NETIF_F_RXCSUM;

			card->dev->vlan_features |= NETIF_F_RXCSUM;

		}

		/* Turn on SG per default */

		card->dev->features |= NETIF_F_SG;

	}

	card->info.broadcast_capable = 1;

	qeth_l2_request_initial_mac(card);

drivers/s390/net/qeth_l3_main.c

+0 −1
Original line number Diff line number Diff line
@@ -3120,7 +3120,6 @@ static int qeth_l3_setup_netdev(struct qeth_card *card) 
				card->dev->vlan_features = NETIF_F_SG |

					NETIF_F_RXCSUM | NETIF_F_IP_CSUM |

					NETIF_F_TSO;

				card->dev->features = NETIF_F_SG;

			}

		}

	} else if (card->info.type == QETH_CARD_TYPE_IQD) {