Commit 56dc57c7 authored Jul 21, 2019 by Navid Emamdoost Committed by Greg Kroah-Hartman Aug 16, 2019

allocate_flower_entry: should check for null deref



[ Upstream commit bb1320834b8a80c6ac2697ab418d066981ea08ba ]

allocate_flower_entry does not check for allocation success, but tries
to deref the result. I only moved the spin_lock under null check, because
 the caller is checking allocation's status at line 652.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f4cfdd46

drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -67,6 +67,7 @@ static struct ch_tc_pedit_fields pedits[] = {
		static struct ch_tc_flower_entry *allocate_flower_entry(void)
		{
		struct ch_tc_flower_entry new = kzalloc(sizeof(new), GFP_KERNEL);
		if (new)
		spin_lock_init(&new->lock);
		return new;
		}