Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56be8895 authored by Jason Gunthorpe's avatar Jason Gunthorpe Committed by Konrad Rzeszutek Wilk
Browse files

tpm: xen-tpmfront: Fix default durations 



All the default durations were being set to 10 minutes which is
way too long for the timeouts. Normal values for the longest
duration are around 5 mins, and short duration ar around .5s.

Further, these are just the default, tpm_get_timeouts will set
them to values from the TPM (or throw an error).

Just remove them.

Acked-by: default avatarDaniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: default avatarJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 6a6f6e72

drivers/char/tpm/xen-tpmfront.c

+0 −7
Original line number Diff line number Diff line
@@ -210,8 +210,6 @@ static struct attribute_group vtpm_attr_grp = { 
	.attrs = vtpm_attrs,

};



#define TPM_LONG_TIMEOUT   (10 * 60 * HZ)



static const struct tpm_vendor_specific tpm_vtpm = {

	.status = vtpm_status,

	.recv = vtpm_recv,
@@ -224,11 +222,6 @@ static const struct tpm_vendor_specific tpm_vtpm = { 
	.miscdev = {

		.fops = &vtpm_ops,

	},

	.duration = {

		TPM_LONG_TIMEOUT,

		TPM_LONG_TIMEOUT,

		TPM_LONG_TIMEOUT,

	},

};



static irqreturn_t tpmif_interrupt(int dummy, void *dev_id)