Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 568e1f65 authored Jul 22, 2015 by Joern Engel Committed by Nicholas Bellinger Jul 30, 2015

target: improve unsupported opcode message



Make the warning about unsupported SCSI opcode more useful:

 - Add in the initiator name so we know who's sending it.
 - Print the warning even for opcodes that spc_parse_cdb() knows about
   but that we don't handle.

Signed-off-by: Joern Engel <joern@purestorage.com>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent c72c5250

drivers/target/target_core_spc.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1390,9 +1390,6 @@ spc_parse_cdb(struct se_cmd cmd, unsigned int size)
		}
		break;
		default:
		pr_warn("TARGET_CORE[%s]: Unsupported SCSI Opcode"
		" 0x%02x, sending CHECK_CONDITION.\n",
		cmd->se_tfo->get_fabric_name(), cdb[0]);
		return TCM_UNSUPPORTED_SCSI_OPCODE;
		}

drivers/target/target_core_transport.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1247,6 +1247,11 @@ target_setup_cmd_from_cdb(struct se_cmd cmd, unsigned char cdb)
		}

		ret = dev->transport->parse_cdb(cmd);
		if (ret == TCM_UNSUPPORTED_SCSI_OPCODE)
		pr_warn_ratelimited("%s/%s: Unsupported SCSI Opcode 0x%02x, sending CHECK_CONDITION.\n",
		cmd->se_tfo->get_fabric_name(),
		cmd->se_sess->se_node_acl->initiatorname,
		cmd->t_task_cdb[0]);
		if (ret)
		return ret;