Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 568488dc authored by Alex Dewar's avatar Alex Dewar Committed by Greg Kroah-Hartman
Browse files

wl3501_cs: Remove unnecessary NULL check 



[ Upstream commit 1d2a85382282e7c77cbde5650335c3ffc6073fa1 ]

In wl3501_detach(), link->priv is checked for a NULL value before being
passed to free_netdev(). However, it cannot be NULL at this point as it
has already been passed to other functions, so just remove the check.

Addresses-Coverity: CID 710499: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200926174558.9436-1-alex.dewar90@gmail.com


Stable-dep-of: 391af06a02e7 ("wifi: wl3501_cs: Fix an error handling path in wl3501_probe()")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5c9e57d4

drivers/net/wireless/wl3501_cs.c

+1 −3
Original line number Diff line number Diff line
@@ -1438,9 +1438,7 @@ static void wl3501_detach(struct pcmcia_device *link) 
	wl3501_release(link);



	unregister_netdev(dev);



	if (link->priv)

		free_netdev(link->priv);

	free_netdev(dev);

}



static int wl3501_get_name(struct net_device *dev, struct iw_request_info *info,