Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56835e6c authored by Borislav Petkov's avatar Borislav Petkov Committed by Rafael J. Wysocki
Browse files

cpufreq / powernow-k8: Fixup missing _PSS objects message 



_PSS objects can also be missing if Cool'N'Quiet is disabled in the
BIOS. Add that to the FW_BUG message for the user to try before updating
her BIOS. Fix formatting while at it.

Acked-by: default avatarMark Langsdorf <mark.langsdorf@amd.com>
Signed-off-by: default avatarBorislav Petkov <borislav.petkov@amd.com>
Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
parent 2d175069

drivers/cpufreq/powernow-k8.c

+7 −4
Original line number Diff line number Diff line
@@ -1265,12 +1265,15 @@ static void __cpuinit powernowk8_cpu_init_on_cpu(void *_init_on_cpu) 
	init_on_cpu->rc = 0;

}



static const char missing_pss_msg[] =

	KERN_ERR

	FW_BUG PFX "No compatible ACPI _PSS objects found.\n"

	FW_BUG PFX "First, make sure Cool'N'Quiet is enabled in the BIOS.\n"

	FW_BUG PFX "If that doesn't help, try upgrading your BIOS.\n";



/* per CPU init entry point to the driver */

static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)

{

	static const char ACPI_PSS_BIOS_BUG_MSG[] =

		KERN_ERR FW_BUG PFX "No compatible ACPI _PSS objects found.\n"

		FW_BUG PFX "Try again with latest BIOS.\n";

	struct powernow_k8_data *data;

	struct init_on_cpu init_on_cpu;

	int rc;
@@ -1298,7 +1301,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol) 
		 * an UP version, and is deprecated by AMD.

		 */

		if (num_online_cpus() != 1) {

			printk_once(ACPI_PSS_BIOS_BUG_MSG);

			printk_once(missing_pss_msg);

			goto err_out;

		}

		if (pol->cpu != 0) {