Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 562088ee authored by Dong Aisheng's avatar Dong Aisheng Committed by Linus Walleij
Browse files

pinctrl: imx: fix unsigned check if nfuncs with less than or equal zero 



The unsigned integer nfuncs is being error checked with a value less
or equal to zero; this is always false if of_get_child_count returns a
-ve for an error condition since nfuncs is not signed. Fix this by
making variables nfuncs and i signed integers.

Detected with Coccinelle:
drivers/pinctrl/freescale/pinctrl-imx.c:620:6-12: WARNING: Unsigned
expression compared with zero: nfuncs <= 0

Cc: Linus Walleij <linus.walleij@linaro.org>
Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent fdab33d5

drivers/pinctrl/freescale/pinctrl-imx.c

+1 −1
Original line number Diff line number Diff line
@@ -617,7 +617,7 @@ static int imx_pinctrl_probe_dt(struct platform_device *pdev, 
		nfuncs = 1;

	} else {

		nfuncs = of_get_child_count(np);

		if (nfuncs <= 0) {

		if (nfuncs == 0) {

			dev_err(&pdev->dev, "no functions defined\n");

			return -EINVAL;

		}