Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55fa328a authored by Devendra Naga's avatar Devendra Naga Committed by Greg Kroah-Hartman
Browse files

staging: octeon-usb: check return value of platform_device_register_simple 



the return value is a pointer having an error set. we have to check for
IS_ERR and return PTR_ERR when appropriate

Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: David Daney <ddaney.cavm@gmail.com>
Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3fa98f34

drivers/staging/octeon-usb/octeon-hcd.c

+4 −2
Original line number Diff line number Diff line
@@ -23,6 +23,8 @@ 


#include <linux/usb/hcd.h>



#include <linux/err.h>



//#define DEBUG_CALL(format, ...)         printk(format, ##__VA_ARGS__)

#define DEBUG_CALL(format, ...)         do {} while (0)

//#define DEBUG_SUBMIT(format, ...)       printk(format, ##__VA_ARGS__)
@@ -781,9 +783,9 @@ static int __init octeon_usb_module_init(void) 
        irq_resource.end = irq_resource.start;

        irq_resource.flags = IORESOURCE_IRQ;

        pdev = platform_device_register_simple((char*)octeon_usb_driver.name, device, &irq_resource, 1);

        if (!pdev) {

        if (IS_ERR(pdev)) {

            DEBUG_FATAL("OcteonUSB: Failed to allocate platform device for USB%d\n", device);

            return -ENOMEM;

            return PTR_ERR(pdev);

        }

        if (device < MAX_USB_PORTS)

            pdev_glob[device] = pdev;