Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 54e5bb46 authored by Jiang Liu's avatar Jiang Liu Committed by Rafael J. Wysocki
Browse files

PCI / pci-label: release allocated ACPI object on error recovery path 



Function dsm_get_label() leaks the returned ACPI object if
obj->package.count is not 2, so fix the possible memory leak.

Signed-off-by: default avatarJiang Liu <jiang.liu@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent a65ac520

drivers/pci/pci-label.c

+4 −8
Original line number Diff line number Diff line
@@ -233,11 +233,7 @@ dsm_get_label(acpi_handle handle, int func, 
		return -1;



	obj = (union acpi_object *)output->pointer;



	switch (obj->type) {

	case ACPI_TYPE_PACKAGE:

		if (obj->package.count != 2)

			break;

	if (obj->type == ACPI_TYPE_PACKAGE && obj->package.count == 2) {

		len = obj->package.elements[0].integer.value;

		if (buf) {

			if (attribute == ACPI_ATTR_INDEX_SHOW)
@@ -250,10 +246,10 @@ dsm_get_label(acpi_handle handle, int func, 
		}

		kfree(output->pointer);

		return len;

	break;

	default:

		kfree(output->pointer);

	}



	kfree(output->pointer);



	return -1;

}