Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 54d52ad9 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Stephen Boyd
Browse files

soc: rockchip: power-domain: Use of_clk_get_parent_count() instead of open coding 



As of_clk_get_parent_count() returns zero on failure, while
of_count_phandle_with_args() might return a negative error code, this
also fixes the issue of possibly using a negative number in the
allocation below.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Reviewed-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent b799cac7

drivers/soc/rockchip/pm_domains.c

+2 −2
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ 
#include <linux/pm_clock.h>

#include <linux/pm_domain.h>

#include <linux/of_address.h>

#include <linux/of_clk.h>

#include <linux/of_platform.h>

#include <linux/clk.h>

#include <linux/regmap.h>
@@ -400,8 +401,7 @@ static int rockchip_pm_add_one_domain(struct rockchip_pmu *pmu, 
	pd->info = pd_info;

	pd->pmu = pmu;



	pd->num_clks = of_count_phandle_with_args(node, "clocks",

						  "#clock-cells");

	pd->num_clks = of_clk_get_parent_count(node);

	if (pd->num_clks > 0) {

		pd->clks = devm_kcalloc(pmu->dev, pd->num_clks,

					sizeof(*pd->clks), GFP_KERNEL);