Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 54b28cdf authored by Jean Pihet's avatar Jean Pihet Committed by Kevin Hilman
Browse files

ARM: OMAP3+: SmartReflex: fix the use of debugfs_create_* API 



The debugfs_create_* API returns a return code or NULL
in the return ptr in case of problem.
Fix the smartreflex code to take this into account.

Signed-off-by: default avatarJean Pihet <j-pihet@ti.com>
Reviewed-by: default avatarKevin Hilman <khilman@ti.com>
Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
parent d6173692

arch/arm/mach-omap2/smartreflex.c

+3 −3
Original line number Diff line number Diff line
@@ -989,7 +989,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) 
	dev_info(&pdev->dev, "%s: SmartReflex driver initialized\n", __func__);

	if (!sr_dbg_dir) {

		sr_dbg_dir = debugfs_create_dir("smartreflex", NULL);

		if (!sr_dbg_dir) {

		if (IS_ERR_OR_NULL(sr_dbg_dir)) {

			ret = PTR_ERR(sr_dbg_dir);

			pr_err("%s:sr debugfs dir creation failed(%d)\n",

				__func__, ret);
@@ -1006,7 +1006,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) 
	}

	sr_info->dbg_dir = debugfs_create_dir(name, sr_dbg_dir);

	kfree(name);

	if (IS_ERR(sr_info->dbg_dir)) {

	if (IS_ERR_OR_NULL(sr_info->dbg_dir)) {

		dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n",

			__func__);

		ret = PTR_ERR(sr_info->dbg_dir);
@@ -1023,7 +1023,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) 
			&sr_info->err_minlimit);



	nvalue_dir = debugfs_create_dir("nvalue", sr_info->dbg_dir);

	if (IS_ERR(nvalue_dir)) {

	if (IS_ERR_OR_NULL(nvalue_dir)) {

		dev_err(&pdev->dev, "%s: Unable to create debugfs directory"

			"for n-values\n", __func__);

		ret = PTR_ERR(nvalue_dir);