Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 547efead authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Thomas Gleixner
Browse files

x86/mtrr: Remove get_online_cpus() from mtrr_save_state() 



mtrr_save_state() is invoked from native_cpu_up() which is in the context
of a CPU hotplug operation and therefor calling get_online_cpus() is
pointless.

While this works in the current get_online_cpus() implementation it
prevents from converting the hotplug locking to percpu rwsems.

Remove it.

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20170524081547.651378834@linutronix.de
parent c5a81c8f

arch/x86/kernel/cpu/mtrr/main.c

+0 −2
Original line number Diff line number Diff line
@@ -807,10 +807,8 @@ void mtrr_save_state(void) 
	if (!mtrr_enabled())

		return;



	get_online_cpus();

	first_cpu = cpumask_first(cpu_online_mask);

	smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1);

	put_online_cpus();

}



void set_mtrr_aps_delayed_init(void)