Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5476b8b2 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

drivers/net/usb: Use kmemdup 

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 99bf2366

drivers/net/usb/dm9601.c

+1 −2
Original line number Diff line number Diff line
@@ -93,10 +93,9 @@ static int dm_write(struct usbnet *dev, u8 reg, u16 length, void *data) 
	netdev_dbg(dev->net, "dm_write() reg=0x%02x, length=%d\n", reg, length);



	if (data) {

		buf = kmalloc(length, GFP_KERNEL);

		buf = kmemdup(data, length, GFP_KERNEL);

		if (!buf)

			goto out;

		memcpy(buf, data, length);

	}



	err = usb_control_msg(dev->udev,