Commit 543db1d9 authored Sep 18, 2020 by Yu Kuai Committed by Greg Kroah-Hartman Oct 07, 2020

iommu/exynos: add missing put_device() call in exynos_iommu_of_xlate()



[ Upstream commit 1a26044954a6d1f4d375d5e62392446af663be7a ]

if of_find_device_by_node() succeed, exynos_iommu_of_xlate() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.

Fixes: aa759fd3 ("iommu/exynos: Add callback for initializing devices from device tree")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20200918011335.909141-1-yukuai3@huawei.com


Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a84da5ea

drivers/iommu/exynos-iommu.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -1302,13 +1302,17 @@ static int exynos_iommu_of_xlate(struct device *dev,
		return -ENODEV;

		data = platform_get_drvdata(sysmmu);
		if (!data)
		if (!data) {
		put_device(&sysmmu->dev);
		return -ENODEV;
		}

		if (!owner) {
		owner = kzalloc(sizeof(*owner), GFP_KERNEL);
		if (!owner)
		if (!owner) {
		put_device(&sysmmu->dev);
		return -ENOMEM;
		}

		INIT_LIST_HEAD(&owner->controllers);
		mutex_init(&owner->rpm_lock);