Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5418ae31 authored by Kees Cook's avatar Kees Cook Committed by Greg Kroah-Hartman
Browse files

staging: dgnc: fix potential format string flaw 



Make sure that format strings cannot leak into printk() calls from the
msgbuf string.

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9edf0f67

drivers/staging/dgnc/dgnc_driver.c

+2 −2
Original line number Diff line number Diff line
@@ -454,7 +454,7 @@ static void dgnc_cleanup_board(struct board_t *brd) 


		DGNC_LOCK(dgnc_global_lock, flags);

		brd->msgbuf = NULL;

		printk(brd->msgbuf_head);

		printk("%s", brd->msgbuf_head);

		kfree(brd->msgbuf_head);

		brd->msgbuf_head = NULL;

		DGNC_UNLOCK(dgnc_global_lock, flags);
@@ -710,7 +710,7 @@ static int dgnc_found_board(struct pci_dev *pdev, int id) 
	DPR_INIT(("dgnc_scan(%d) - printing out the msgbuf\n", i));

	DGNC_LOCK(dgnc_global_lock, flags);

	brd->msgbuf = NULL;

	printk(brd->msgbuf_head);

	printk("%s", brd->msgbuf_head);

	kfree(brd->msgbuf_head);

	brd->msgbuf_head = NULL;

	DGNC_UNLOCK(dgnc_global_lock, flags);