Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5413eaba authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: pcf85063: return an error when date is invalid



Return an error when the date is invalid as the policy should be
implemented there.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent b1f9d790
Loading
Loading
Loading
Loading
+1 −7
Original line number Diff line number Diff line
@@ -80,13 +80,7 @@ static int pcf85063_get_datetime(struct i2c_client *client, struct rtc_time *tm)
	pcf85063->c_polarity = (buf[PCF85063_REG_MO] & PCF85063_MO_C) ?
		(tm->tm_year >= 100) : (tm->tm_year < 100);

	/* the clock can give out invalid datetime, but we cannot return
	 * -EINVAL otherwise hwclock will refuse to set the time on bootup.
	 */
	if (rtc_valid_tm(tm) < 0)
		dev_err(&client->dev, "retrieved date/time is not valid.\n");

	return 0;
	return rtc_valid_tm(tm);
}

static int pcf85063_set_datetime(struct i2c_client *client, struct rtc_time *tm)