Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 540b5d02 authored by Chris Wilson's avatar Chris Wilson Committed by Daniel Vetter
Browse files

drm/i915: Add breadcrumbs for why the backlight is being set 



At the moment we have 3 paths that lead to actually_set_backlight(),
from modesetting, ACPI/OpRegion requests and our very own
intel_backlight interface, and we have no way of distinguishing them in
the debug log. So add a debug breadcrumb to explain the source of the
backlight changes.

Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 391f75e2

drivers/gpu/drm/i915/intel_opregion.c

+1 −0
Original line number Diff line number Diff line
@@ -407,6 +407,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) 
	if (bclp > 255)

		return ASLC_BACKLIGHT_FAILED;



	DRM_DEBUG_KMS("updating opregion backlight %d/255\n", bclp);

	intel_panel_set_backlight(dev, bclp, 255);

	iowrite32(DIV_ROUND_UP(bclp * 100, 255) | ASLE_CBLV_VALID, &asle->cblv);

drivers/gpu/drm/i915/intel_panel.c

+4 −0
Original line number Diff line number Diff line
@@ -574,6 +574,8 @@ void intel_panel_enable_backlight(struct drm_device *dev, 
		intel_pipe_to_cpu_transcoder(dev_priv, pipe);

	unsigned long flags;



	DRM_DEBUG_KMS("pipe=%d\n", pipe);



	spin_lock_irqsave(&dev_priv->backlight.lock, flags);



	if (dev_priv->backlight.level == 0) {
@@ -680,6 +682,8 @@ intel_panel_detect(struct drm_device *dev) 
static int intel_panel_update_status(struct backlight_device *bd)

{

	struct drm_device *dev = bl_get_data(bd);

	DRM_DEBUG_KMS("updating intel_backlight, brightness=%d/%d\n",

		      bd->props.brightness, bd->props.max_brightness);

	intel_panel_set_backlight(dev, bd->props.brightness,

				  bd->props.max_brightness);

	return 0;