Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53e720f3 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Felipe Balbi
Browse files

usb: gadget: udc: add null check before pointer dereference 



Add null check before dereferencing dev->regs pointer inside
net2280_led_shutdown() function.

Addresses-Coverity-ID: 101783
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent d94e64cb

drivers/usb/gadget/udc/net2280.c

+3 −2
Original line number Diff line number Diff line
@@ -3573,7 +3573,6 @@ static void net2280_remove(struct pci_dev *pdev) 
	BUG_ON(dev->driver);



	/* then clean up the resources we allocated during probe() */

	net2280_led_shutdown(dev);

	if (dev->requests) {

		int		i;

		for (i = 1; i < 5; i++) {
@@ -3588,8 +3587,10 @@ static void net2280_remove(struct pci_dev *pdev) 
		free_irq(pdev->irq, dev);

	if (dev->quirks & PLX_PCIE)

		pci_disable_msi(pdev);

	if (dev->regs)

	if (dev->regs) {

		net2280_led_shutdown(dev);

		iounmap(dev->regs);

	}

	if (dev->region)

		release_mem_region(pci_resource_start(pdev, 0),

				pci_resource_len(pdev, 0));