Commit 53e20f2e authored Jul 19, 2015 by Alexey Khoroshilov Committed by Felipe Balbi Jul 20, 2015

usb: gadget: mv_udc_core: fix phy_regs I/O memory leak



There was an omission in transition to devm_xxx resource handling.
iounmap(udc->phy_regs) were removed, but ioremap() was left
without devm_.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 3517c31a ("usb: gadget: mv_udc: use devm_xxx for probe")
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent 4696b887

drivers/usb/gadget/udc/mv_udc_core.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2167,7 +2167,7 @@ static int mv_udc_probe(struct platform_device *pdev)
	return -ENODEV;		return -ENODEV;
	}		}

	udc->phy_regs = ioremap(r->start, resource_size(r));		udc->phy_regs = devm_ioremap(&pdev->dev, r->start, resource_size(r));
	if (udc->phy_regs == NULL) {		if (udc->phy_regs == NULL) {
	dev_err(&pdev->dev, "failed to map phy I/O memory\n");		dev_err(&pdev->dev, "failed to map phy I/O memory\n");
	return -EBUSY;		return -EBUSY;