Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53b4e073 authored by Michal Kazior's avatar Michal Kazior Committed by Kalle Valo
Browse files

ath10k: remove ar_pci->started 



There are basically no more uses for
ar_pci->started. It is also perfectly safe to call
hif_stop without hif_start now.

Signed-off-by: default avatarMichal Kazior <michal.kazior@tieto.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent cf5dd36d

drivers/net/wireless/ath/ath10k/pci.c

+0 −10
Original line number Original line Diff line number Diff line
@@ -1115,14 +1115,11 @@ static void ath10k_pci_irq_enable(struct ath10k *ar) 




static int ath10k_pci_hif_start(struct ath10k *ar)

static int ath10k_pci_hif_start(struct ath10k *ar)

{

{

	struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);



	ath10k_dbg(ATH10K_DBG_BOOT, "boot hif start\n");

	ath10k_dbg(ATH10K_DBG_BOOT, "boot hif start\n");





	ath10k_pci_irq_enable(ar);

	ath10k_pci_irq_enable(ar);

	ath10k_pci_rx_post(ar);

	ath10k_pci_rx_post(ar);





	ar_pci->started = 1;

	return 0;

	return 0;

}

}
@@ -1225,13 +1222,8 @@ static void ath10k_pci_flush(struct ath10k *ar) 




static void ath10k_pci_hif_stop(struct ath10k *ar)

static void ath10k_pci_hif_stop(struct ath10k *ar)

{

{

	struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);



	ath10k_dbg(ATH10K_DBG_BOOT, "boot hif stop\n");

	ath10k_dbg(ATH10K_DBG_BOOT, "boot hif stop\n");





	if (WARN_ON(!ar_pci->started))

		return;



	ath10k_pci_irq_disable(ar);

	ath10k_pci_irq_disable(ar);

	ath10k_pci_flush(ar);

	ath10k_pci_flush(ar);
@@ -1240,8 +1232,6 @@ static void ath10k_pci_hif_stop(struct ath10k *ar) 
	 * memory is to reset the chip now.

	 * memory is to reset the chip now.

	 */

	 */

	ath10k_pci_warm_reset(ar);

	ath10k_pci_warm_reset(ar);



	ar_pci->started = 0;

}

}





static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar,

static int ath10k_pci_hif_exchange_bmi_msg(struct ath10k *ar,

drivers/net/wireless/ath/ath10k/pci.h

+0 −2
Original line number Original line Diff line number Diff line
@@ -167,8 +167,6 @@ struct ath10k_pci { 
	struct tasklet_struct intr_tq;

	struct tasklet_struct intr_tq;

	struct tasklet_struct msi_fw_err;

	struct tasklet_struct msi_fw_err;





	int started;



	struct ath10k_pci_pipe pipe_info[CE_COUNT_MAX];

	struct ath10k_pci_pipe pipe_info[CE_COUNT_MAX];





	struct ath10k_hif_cb msg_callbacks_current;

	struct ath10k_hif_cb msg_callbacks_current;