Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53b3847b authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller
Browse files

net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags 



Currently gen_flags is being operated on by a logical && operator rather
than a bitwise & operator. This looks incorrect as these should be bit
flag operations. Fix this.

Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")

Fixes: 3f7889c4 ("net: sched: cls_bpf: call block callbacks for offload)
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9eba9353

net/sched/cls_bpf.c

+1 −1
Original line number Diff line number Diff line
@@ -174,7 +174,7 @@ static int cls_bpf_offload_cmd(struct tcf_proto *tp, struct cls_bpf_prog *prog, 
		}

	}



	if (addorrep && skip_sw && !(prog->gen_flags && TCA_CLS_FLAGS_IN_HW))

	if (addorrep && skip_sw && !(prog->gen_flags & TCA_CLS_FLAGS_IN_HW))

		return -EINVAL;



	return 0;