Commit 5360943f authored Nov 18, 2016 by Ville Syrjälä

drm/qxl: Call drm_helper_mode_fill_fb_struct() before drm_framebuffer_init()

We want framebuffers to be mostly useable already before
drm_framebuffer_init() is called, and so we will start demanding that
all the interesting format/size/etc. information be filled in before
drm_framebuffer_init(). drm_helper_mode_fill_fb_struct() will do that
for us, so let's make sure it gets called before drm_framebuffer_init().

Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1479498793-31021-16-git-send-email-ville.syrjala@linux.intel.com

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

parent a3f913ca

drivers/gpu/drm/qxl/qxl_display.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -624,12 +624,12 @@ qxl_framebuffer_init(struct drm_device *dev,
		int ret;

		qfb->obj = obj;
		drm_helper_mode_fill_fb_struct(dev, &qfb->base, mode_cmd);
		ret = drm_framebuffer_init(dev, &qfb->base, funcs);
		if (ret) {
		qfb->obj = NULL;
		return ret;
		}
		drm_helper_mode_fill_fb_struct(dev, &qfb->base, mode_cmd);
		return 0;
		}