Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53098091 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Add explicit zeroing to "envp" array in device 'show' method 



As Stephen Hemminger says, this is a "belt and suspenders" patch that
zeroes the envp array at allocation time, even though all the users
should NULL-terminate it anyway (and we've hopefully fixed everybody
that doesn't do that).

And we'll apparently clean the whole envp thing up for 2.6.24 anyway.

But let's just be robust, and do both this *and* make sure that all
users are doing the right thing.

Acked-by: default avatarStephen Hemminger <shemminger@linux-foundation.org>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 544002ef

drivers/base/core.c

+1 −0
Original line number Diff line number Diff line
@@ -284,6 +284,7 @@ static ssize_t show_uevent(struct device *dev, struct device_attribute *attr, 


	/* let the kset specific function add its keys */

	pos = data;

	memset(envp, 0, sizeof(envp));

	retval = kset->uevent_ops->uevent(kset, &dev->kobj,

					  envp, ARRAY_SIZE(envp),

					  pos, PAGE_SIZE);