Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52dfa12e authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Daniel Vetter
Browse files

drm/gma500: fix error path in gma_intel_setup_gmbus() 



The current code fails to call i2c_del_adapter on
dev_prev->gmbus[0].adapter, and if the for loop above failed already
at i==0, all hell breaks loose when we do the loop body for
i = -1,-2,...

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Link: http://patchwork.freedesktop.org/patch/msgid/1455048677-19882-2-git-send-email-linux@rasmusvillemoes.dk


Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 4c61716c

drivers/gpu/drm/gma500/intel_gmbus.c

+1 −1
Original line number Diff line number Diff line
@@ -436,7 +436,7 @@ int gma_intel_setup_gmbus(struct drm_device *dev) 
	return 0;



err:

	while (--i) {

	while (i--) {

		struct intel_gmbus *bus = &dev_priv->gmbus[i];

		i2c_del_adapter(&bus->adapter);

	}